-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure prefixcontext/suffixcontent shown for all lines in a multi-line message #483
Conversation
fed5e54
to
718d816
Compare
@hloeung can you look at the conflicts below (bridge/mattermost6/mattermost.go)? |
@42wim ok removed that block |
This is getting a bit too complex though :/ It doesn't seem to work correctly when using prefixcontext
and only replying on with hidecontextmulti disabled it gives me this
(replying on while what I actually want is
Other comments on the changes:
|
098cfef
to
b3ee30f
Compare
@42wim , okay, try it out now! I did some testing with all combinations I can think of.
|
Thanks a lot for your work / time on this! |
* Do not split message on newlines This fixes #480 and as a bonus also fixes #426 as this is now just 1 big message for irc See also #483 * Check code block start on multiple lines * Ensure prefixcontext/suffixcontent shown for all lines in a multi-line message (#483) * Ensure prefixcontext/suffixcontent shown for all lines in a multi-line message * Make showing context for multi-line messages configurable * Fix to handle empty lines now that we're splitting elsewhere * Restore changes to MsgSpoofUser() and Spoof() per review * Allow overriding max. line length * Fix to correctly add message thread context * Refactor and remove duplicate code per review Co-authored-by: Haw Loeung <haw.loeung@canonical.com>
With the new no splitting multi-line messages in PR #482, multi-line messages are displayed as:
Unfortunately, it means using tools such as grepping won't show all the lines as part of the message. This fixes that: