Reduce UpdateChannelsTeam() calls #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
reduce-update-channel-teams
branch
2 times, most recently
from
2947668 to
8356694
Compare
hloeung
force-pushed
the
reduce-update-channel-teams
branch
7 times, most recently
from
7422115 to
a41f165
Compare
We only need to call this for when channels and user changes. This fixes 42wim#492.
|
If we update channels cache on user removal, we get this: Removing it seems to silence this so I'm going with that. |
hloeung
force-pushed
the
reduce-update-channel-teams
branch
from
a41f165 to
f84bf6f
Compare
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to call this for when channels and user changes. This fixes #492.