Cache last sent msgs #520
Merged
Cache last sent msgs #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
cache-last-sent-msgs
branch
2 times, most recently
from
68e09fb to
6841889
Compare
hloeung
force-pushed
the
cache-last-sent-msgs
branch
from
528c5de to
46d218b
Compare
hloeung
force-pushed
the
cache-last-sent-msgs
branch
from
46d218b to
4c31930
Compare
42wim
reviewed
Mar 29, 2023
| } | ||
| } | ||
|
|
||
| return false | ||
| m.msgLastSentCache.Add(msgID, fmt.Sprintf("%s: %s", channel, msg)) |
There was a problem hiding this comment.
wrt to line 732 to 751
I must be missing something but why do you want to add a message that's going to be skipped in to the cache?
There was a problem hiding this comment.
This is the only way we can get the message IDs for these messages we've sent. It goes through the server and back to us and that's when we add it to the cache.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly useful for seeing what your last replies/posts were, especially when using
@@!!.