Fix incorrect msg/thread counters #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
msgcounter-lock
branch
8 times, most recently
from
0ac9283 to
c80eb79
Compare
hloeung
force-pushed
the
msgcounter-lock
branch
3 times, most recently
from
bfdad41 to
e27b4cc
Compare
When using mattericd's default threading, the msgMap is populated with message/thred IDs and never removed. This means that when we cycle past 4k, we can have entries with duplicate counters causing issues when replying to threads. This fixes it by introducing an index.
hloeung
force-pushed
the
msgcounter-lock
branch
2 times, most recently
from
901c035 to
523a108
Compare
This is so we don't get something like same counter for both parent and message when wrapping past the maximum counter value. e.g. | |15:54 <@bob> [↪005,005] my message ...
hloeung
force-pushed
the
msgcounter-lock
branch
from
523a108 to
1ec19f3
Compare
42wim
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using mattericd's default threading, the msgMap is populated with message/thread IDs and never removed. This means that when we cycle past 4k, we can have entries with duplicate counters causing issues where replies could end up to an incorrect thread.
This fixes it by introducing an index with the counter and to which message/thread ID. When index entries are updated and the thread no longer referenced, the entries in the msgMap are removed.
This also ensures that msgMap remains a constant bounded size.
It should be noted that this also relies on #544, in particular https://github.com/42wim/matterircd/blob/master/mm-go-irckit/server_commands.go#L665