Convert Mattermost markdown formatting / emphasis to IRC #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
convert-formatting-mattermost
branch
2 times, most recently
from
f9bce48 to
c0884d2
Compare
hloeung
force-pushed
the
convert-formatting-mattermost
branch
from
c0884d2 to
010ab9e
Compare
Not all IRC clients support this yet, let's just drop it for now to avoid having weird and funny characters appearing.
hloeung
force-pushed
the
convert-formatting-mattermost
branch
4 times, most recently
from
08da552 to
4906ae0
Compare
hloeung
force-pushed
the
convert-formatting-mattermost
branch
from
4906ae0 to
98a3ead
Compare
|
Looks good, I'm wondering if it should be an option for people who want to disable it |
hloeung
force-pushed
the
convert-formatting-mattermost
branch
from
b8b64b8 to
3bc2cf3
Compare
|
Sure, made an option to disable it. Thanks and much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the reverse of #546 for #258, convert Mattermost posts with markdown formatting / emphasis to IRC. Example:
Becomes:
(FWIW, monospace support was added in irssi 1.4.4, I'm running 1.4.3 and why it's showing as
Q)