Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use static initialisation for regular expressions to optimize #551

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Use static initialisation for regular expressions to optimize #551

merged 1 commit into from
Sep 29, 2023

Conversation

hloeung
Copy link
Collaborator

@hloeung hloeung commented Sep 27, 2023

@hloeung hloeung marked this pull request as ready for review September 28, 2023 01:23
42wim
42wim approved these changes Sep 29, 2023
View reviewed changes
Copy link
Owner

@42wim 42wim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hloeung hloeung merged commit 62f6234 into 42wim:master Sep 29, 2023
4 checks passed
@hloeung hloeung deleted the regexp branch September 29, 2023 20:25
@42wim 42wim added this to the 0.28.0 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42wim 42wim 42wim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hloeung @42wim