Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use palette for colors #94

Draft
wants to merge 21 commits into
base: v0.8-pre
Choose a base branch
from
Draft

Use palette for colors #94

wants to merge 21 commits into from

Conversation

MathNuba
Copy link
Collaborator

Issues #78

@OlivierLemoine OlivierLemoine self-requested a review March 11, 2024 15:32
@OlivierLemoine OlivierLemoine added this to the v0.8 milestone Mar 11, 2024
@OlivierLemoine OlivierLemoine linked an issue Mar 11, 2024 that may be closed by this pull request
Use palette for colors #78
Open
MathNuba and others added 6 commits March 11, 2024 16:43
@MathNuba
Should work
a8b09b3
@OlivierLemoine
Update examples
298c01b
@MathNuba
Correct dessin-svg
b6a08e0 
svg chang wanted :
-yellow_thick_arc : show transparency
-right_angle_triangle : show transparency
-red_circle
-purple_padding : move to purple color
-green_rectangle
@MathNuba
Erase old rgb
4534910
@MathNuba
Same as before
55dc747
@OlivierLemoine
Update examples
6aa29f3
@OlivierLemoine
Copy link
Member

Je mets en pause pour l'instant. L'implémentation est bonne, mais les couleurs sont trop verbeuses. On verra pour trouver une meilleure solution

@OlivierLemoine OlivierLemoine marked this pull request as draft March 25, 2024 14:42
@OlivierLemoine
Copy link
Member

  1. Faire que fill(...) accepte un T ou T: Into<Srgb>

Si ça ne marche pas:
2. Créer une struct Color(pub Srgb);
impl From<Rgb> for Color {...}
impl From<Rgb> for Color {...}
impl From<Rgba> for Color {...}
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierLemoine OlivierLemoine Awaiting requested review from OlivierLemoine

At least 1 approving review is required to merge this pull request.

Assignees

@MathNuba MathNuba

Labels
A-dessin
Projects
Dessin
Status: No status
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Use palette for colors
2 participants
@MathNuba @OlivierLemoine