Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integration tests creating statuses #128

Merged
merged 1 commit into from
May 10, 2017

Conversation

BenFradet
Copy link
Contributor

This is causing the current builds to fail as we've recently reached the limit of 1k statuses for the commit sha we use to create statuses in the integration tests.

@codecov-io
Copy link

codecov-io commented May 10, 2017

Codecov Report

Merging #128 into master will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   89.01%   88.44%   -0.57%     
==========================================
  Files          38       38              
  Lines         528      528              
  Branches        2        2              
==========================================
- Hits          470      467       -3     
- Misses         58       61       +3
Impacted Files Coverage Δ
...c/main/scala/github4s/free/algebra/StatusOps.scala 60% <0%> (-40%) ⬇️
...cala/github4s/free/interpreters/Interpreters.scala 83.58% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db60312...71f2773. Read the comment docs.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@fedefernandez fedefernandez merged commit f8233d9 into master May 10, 2017
@fedefernandez fedefernandez deleted the bf-create-status-integ branch May 10, 2017 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants