Refactor Algebras #130
Merged
Refactor Algebras #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 11, 2017 13:28
minor doc fixed
minor notification fixes minor doc fixes minor style reformat
Docs ready to add repo doc minor fixes
refactor commit
BenFradet
reviewed
May 12, 2017
docs/src/main/tut/repo.md
Outdated
| Github4s supports the [Repository API](https://developer.github.com/v3/repos/). As a result, | ||
| with github4s, you can: | ||
|
|
||
| - [Get repository](#get-repository) |
docs/src/main/tut/repo.md
Outdated
| } | ||
| ``` | ||
|
|
||
| The `result` on the right is the created [List[Commit]][commit-scala]. |
There was a problem hiding this comment.
created -> corresponding
docs/src/main/tut/repo.md
Outdated
|
|
||
| As a result, if you'd like to see a feature supported, feel free to create an issue and/or a pull request! | ||
|
|
||
| [repository-scala]: https://github.com/47deg/github4s/blob/master/github4s/`SHA`red/src/main/scala/github4s/free/domain/Repository.scala |
There was a problem hiding this comment.
the following links are missing / reference nothing:
- status-scala -> repository-scala
- commit-scala -> repository-scala
- user-scala
- release-scala -> repository-scala
- content-scala -> repository-scala
| @@ -135,7 +135,7 @@ class Repos[C, M[_]]( | |||
| ) | |||
|
|
|||
| /** | |||
| * Fetch contributors list for the the specified repository, | |||
| * Fetch contributors listStatus for the the specified repository, | |||
There was a problem hiding this comment.
I don't think this is necessary
| @@ -175,7 +175,7 @@ class Repos[C, M[_]]( | |||
| * @param targetCommitish specifies the commitish value that determines where the Git tag is created from. | |||
| * Can be any branch or commit SHA. Unused if the Git tag already exists. | |||
| * Default: the repository's default branch (usually `master`). | |||
| * @param draft `true` to create a draft (unpublished) release, `false` to create a published one. | |||
| * @param draft `true` to createStatus a draft (unpublished) release, `false` to createStatus a published one. | |||
There was a problem hiding this comment.
replace all is not a good idea! 😄
There was a problem hiding this comment.
it was a problem with refactor rename in intellij, I'm sorry
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
========================================
- Coverage 88.1% 88% -0.11%
========================================
Files 38 36 -2
Lines 555 550 -5
Branches 2 2
========================================
- Hits 489 484 -5
Misses 66 66
Continue to review full report at Codecov.
|
added 3 commits
May 12, 2017 11:40
fedefernandez
approved these changes
May 12, 2017
| @@ -211,15 +225,15 @@ class Interpreters[M[_], C]( | |||
| /** | |||
| * Lifts Notification Ops to an effect capturing Monad such as Task via natural transformations | |||
There was a problem hiding this comment.
Notification -> Activity
|
|
||
| "Notification." should "call to httpClient.put with the right parameters" in { | ||
| "Activity.SetThreadSubscription" should "call to httpClient.put with the right parameters" in { |
There was a problem hiding this comment.
Activity.setThreadSub
|
|
||
| "Notifications.SetThreadSubscription" should "call to NotificationOps with the right parameters" in { | ||
| "Activities.SetThreadSubscription" should "call to ActivityOps with the right parameters" in { |
There was a problem hiding this comment.
Activities.setThreadSub
| @@ -87,4 +87,56 @@ class ReposSpec extends BaseSpec { | |||
| ) | |||
| } | |||
|
|
|||
| "Repos.get" should "call httpClient.get with the right parameters" in { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129 Refactor status and notification algebras and their docs.
Create repository documentation