-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add get tree api implementation #217
Conversation
Hi @fedefernandez - as requested, I have added some integration tests. Best regards! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, the code looks great. Thanks!
owner: String, | ||
repo: String, | ||
sha: String, | ||
recursive: Boolean=false): M[GHResponse[TreeResult]] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the recursive
param to the scaladoc?
Also, please, add spaces after and before of the =
sign (recursive: Boolean = false
)
@@ -57,7 +57,8 @@ case class TreeDataBlob(path: String, mode: String, `type`: String, content: Str | |||
case class TreeResult( | |||
override val sha: String, | |||
override val url: String, | |||
tree: List[TreeDataResult]) | |||
tree: List[TreeDataResult], | |||
truncated: Option[Boolean]=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- truncated: Option[Boolean]=None
++ truncated: Option[Boolean] = None
Thanks for the feedback - fixed the spacing/documentation issues. Cheers! |
hey @aberey , The tests are failing:
|
@BenFradet I'm sorry, apparently I had some sbt cache issues, which I resolved now. Actually it turned out I was not setting the url parameter via the appropriate API, which I fixed now as well. I double-checked the tests are passing successfully in my local environment. |
Thanks, merging 👍 |
Implemented missing parts of the Git Tree API:
https://developer.github.com/v3/git/trees/#get-a-tree