Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump sbt-org-policies to 0.9.4 #223

Merged
merged 4 commits into from
Oct 3, 2018
Merged

Bump sbt-org-policies to 0.9.4 #223

merged 4 commits into from
Oct 3, 2018

Conversation

BenFradet
Copy link
Contributor

No description provided.

@BenFradet
Copy link
Contributor Author

https://travis-ci.org/47deg/github4s/jobs/436044760#L1332

Weird, I think I've seen this one in the past

@juanpedromoreno
Copy link
Member

Weird indeed. Should we bump up the Scalajs version too?

@BenFradet
Copy link
Contributor Author

We might, the tests run fine locally, so there might be an issue with travis (again)

@BenFradet BenFradet force-pushed the sbt-org-policies-0.9.4 branch 2 times, most recently from 7702279 to 440665e Compare October 3, 2018 11:10
@BenFradet
Copy link
Contributor Author

Fixed! it was due to an outdated version of node 👍

@fedefernandez
Copy link
Contributor

Good catch

@BenFradet
Copy link
Contributor Author

Added a commit to release 0.19.0 given the various important dependency bumps

juanpedromoreno
juanpedromoreno approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@BenFradet BenFradet merged commit ea362bb into master Oct 3, 2018
@BenFradet BenFradet deleted the sbt-org-policies-0.9.4 branch October 3, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@fedefernandez fedefernandez fedefernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenFradet @juanpedromoreno @fedefernandez