-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a way to distinguish different github errors #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that I think this just ends up being a rename of UnexpectedException
if I'm not mistaken?
@BenFradet |
Ah yes forgot about those damned |
@BenFradet Agree, I'll do that |
you need to rename the other 2 occurrences 👍 |
@BenFradet Silly mistake. Apologies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the tests successfully 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikegirkin !
I discovered that there is not way to distinguish between different type of errors in the application using github4s.
This small PR introduces another type for the errors, so the consumer get more information to deal with: