-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the list branched endpoint (47deg#231) #232
Conversation
github4s/shared/src/main/scala/github4s/free/algebra/RepositoryOps.scala
Outdated
Show resolved
Hide resolved
@YarekTyshchenko Apart from the minor typo, the decoders for the new entities ( It should not be hard to add, but let me know if you need help doing so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YarekTyshchenko as it is described in the GitHub API Docs # list-branches, protected
and protection*
keys are only included in the JSON response if the query parameter protected
is set to true
in the request.
That makes the protected
and protection_url
in the response Option
values, IMHO. I've just suggested those changes, but feel free to submit any other possible solution 👍
Also, I think it would be great to test both cases, with protected
and without protected
query parameter. What do you think?
github4s/shared/src/main/scala/github4s/free/domain/Repository.scala
Outdated
Show resolved
Hide resolved
github4s/shared/src/main/scala/github4s/free/domain/Repository.scala
Outdated
Show resolved
Hide resolved
@JesusMtnez You are right, I must have missed that bit in the docs. |
Co-Authored-By: YarekTyshchenko <yarek@healthforge.io>
I could use some help figuring out why the Travis tests are failing. I can't see anything obvious that I did wrong in Repos.scala. I'm not massively familiar with Scala yet |
hey @YarekTyshchenko, the tests use a GitHub token that is not available in forks. You'd need to create a Personal Access token in Github with |
441130e
to
237fc65
Compare
@YarekTyshchenko Greenlight! All checks are passing, we are good to merge. |
@YarekTyshchenko do you need a new release of |
@JesusMtnez Let me have a quick look at #233 first. I think that should be an easy one |
No description provided.