Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused implementation #3

Merged
merged 3 commits into from
May 12, 2016
Merged

Conversation

rafaparadela
Copy link

Since we don't need to split GHResult, this PR simplifies how the response is returned. Some unused algebras have been removed as well.

@FPerezP Could you review please?

@FPerezP
Copy link

FPerezP commented May 12, 2016

Looks good.

Rafa Paradela added 2 commits May 12, 2016 18:01
# Conflicts:
#	src/test/scala/GHReposSpec.scala
#	src/test/scala/com.fortysevendeg.github4s/integration/GHAuthSpec.scala
#	src/test/scala/com.fortysevendeg.github4s/integration/GHUsersSpec.scala
@rafaparadela rafaparadela merged commit 0646b4d into master May 12, 2016
@rafaparadela rafaparadela deleted the rafa-ghresponse-simplification branch May 12, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants