Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Scalajs & Scala 2.11 support #309

Merged
merged 7 commits into from
Dec 18, 2019

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Dec 17, 2019

It also:

  • Upgrades sbt-microsites.
  • Adds some scalafmt format due to the newer version provided by sbt-org-policies.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@aebaa74). Click here to learn what that means.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #309   +/-   ##
=========================================
  Coverage          ?   87.85%           
=========================================
  Files             ?       37           
  Lines             ?      700           
  Branches          ?        5           
=========================================
  Hits              ?      615           
  Misses            ?       85           
  Partials          ?        0
Impacted Files Coverage Δ
github4s/src/main/scala/github4s/Implicits.scala 33.33% <ø> (ø)
...ala/github4s/cats/effect/SyncCaptureInstance.scala 100% <ø> (ø)
...cala/github4s/HttpRequestBuilderExtensionJVM.scala 100% <ø> (ø)
github4s/src/main/scala/github4s/api/Repos.scala 95.45% <ø> (ø)
...4s/src/main/scala/github4s/api/Organizations.scala 100% <ø> (ø)
.../main/scala/github4s/free/domain/PullRequest.scala 100% <ø> (ø)
github4s/src/main/scala/github4s/api/Users.scala 100% <ø> (ø)
...ub4s/src/main/scala/github4s/GithubResponses.scala 100% <ø> (ø)
...src/main/scala/github4s/free/algebra/UserOps.scala 100% <ø> (ø)
...b4s/src/main/scala/github4s/jvm/ImplicitsJVM.scala 100% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebaa74...d541365. Read the comment docs.

.travis.yml Outdated

before_script:
- sudo chmod +x /usr/local/bin/sbt
# Disabled due to unrelated conflicts running the build in travis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@juanpedromoreno juanpedromoreno marked this pull request as ready for review December 18, 2019 10:11
@juanpedromoreno juanpedromoreno merged commit 8b8d0e2 into master Dec 18, 2019
@juanpedromoreno juanpedromoreno deleted the removes-scalajs-scala-211-support branch December 18, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants