-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tut by mdoc and other clean ups #330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
- Coverage 87.85% 87.71% -0.15%
==========================================
Files 37 37
Lines 700 700
Branches 5 2 -3
==========================================
- Hits 615 614 -1
- Misses 85 86 +1
Continue to review full report at Codecov.
|
extends FutureCaptureInstance | ||
with EvalInstances | ||
with IdInstances | ||
with FutureInstances | ||
|
||
object implicits1 extends Instances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you choose implicits1
@BenFradet ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to avoid the clash with implicits
since these are internal I went for implicits
, if you have an idea for a better name I'm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A friend of us always said that the two hardest things in the engineering are cache invalidation and naming 😂 ... and I agree
No description provided.