Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tut by mdoc and other clean ups #330

Merged
merged 9 commits into from
Jan 24, 2020
Merged

Replace tut by mdoc and other clean ups #330

merged 9 commits into from
Jan 24, 2020

Conversation

BenFradet
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #330 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   87.85%   87.71%   -0.15%     
==========================================
  Files          37       37              
  Lines         700      700              
  Branches        5        2       -3     
==========================================
- Hits          615      614       -1     
- Misses         85       86       +1
Impacted Files Coverage Δ
...cala/github4s/HttpRequestBuilderExtensionJVM.scala 100% <ø> (ø) ⬆️
...hub4s/src/main/scala/github4s/api/Activities.scala 100% <ø> (ø) ⬆️
github4s/src/main/scala/github4s/GithubAPIs.scala 100% <ø> (ø) ⬆️
github4s/src/main/scala/github4s/Decoders.scala 96.26% <ø> (ø) ⬆️
...b4s/src/main/scala/github4s/api/PullRequests.scala 100% <ø> (ø) ⬆️
github4s/src/main/scala/github4s/api/Issues.scala 100% <ø> (ø) ⬆️
github4s/src/main/scala/github4s/api/Repos.scala 95.45% <ø> (ø) ⬆️
...4s/src/main/scala/github4s/api/Organizations.scala 100% <ø> (ø) ⬆️
github4s/src/main/scala/github4s/api/Gists.scala 100% <ø> (ø) ⬆️
github4s/src/main/scala/github4s/api/Users.scala 100% <ø> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f1f29...4aaedcb. Read the comment docs.

extends FutureCaptureInstance
with EvalInstances
with IdInstances
with FutureInstances

object implicits1 extends Instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you choose implicits1 @BenFradet ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to avoid the clash with implicits since these are internal I went for implicits, if you have an idea for a better name I'm 👍

Copy link
Contributor

@fedefernandez fedefernandez Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A friend of us always said that the two hardest things in the engineering are cache invalidation and naming 😂 ... and I agree

@rafaparadela rafaparadela merged commit aabb345 into master Jan 24, 2020
@rafaparadela rafaparadela deleted the mdoc branch January 24, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants