Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames Token Env Var #397

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Conversation

juanpedromoreno
Copy link
Member

GITHUB_TOKEN is added by GH actions by default.

Fixes #396

@juanpedromoreno
Copy link
Member Author

I've created this PR from a fork. You can now see that the Integration tests are skipped. For example https://github.com/47degrees/github4s/pull/397/checks?check_run_id=541849740#step:5:437

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@BenFradet BenFradet merged commit f70ced8 into 47degrees:master Mar 28, 2020
@juanpedromoreno juanpedromoreno deleted the patch-it-in-forks branch March 28, 2020 16:06
@BenFradet
Copy link
Contributor

it seems we might need both 🤔 : https://github.com/47degrees/github4s/runs/541883949#step:6:322

@juanpedromoreno
Copy link
Member Author

@BenFradet that's a different workflow. I'm fixing that particular problem here ;)

https://github.com/47degrees/.github/pull/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests are run when the token is not present
2 participants