Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformize pagination usage #443

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Uniformize pagination usage #443

merged 3 commits into from
Apr 15, 2020

Conversation

BenFradet
Copy link
Contributor

No description provided.

@BenFradet BenFradet mentioned this pull request Apr 10, 2020
Closed
juanpedromoreno
juanpedromoreno approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on green

@BenFradet
Copy link
Contributor Author

Thanks for the review 👍 , went mindlessly through the algebras

@BenFradet
Copy link
Contributor Author

BenFradet commented Apr 14, 2020 •
edited
Loading

I think this is good to go now 👍 cc @dcsobral

@BenFradet BenFradet added the breaking-change A breaking change that needs to be treated with consideration label Apr 14, 2020
@dcsobral
Copy link
Contributor

@BenFradet This will conflict with #462 , and introduces more cases of #449 . It will be easier if this is cleared of that issue, merged, and then #462 rebased on top of it.

@BenFradet
Copy link
Contributor Author

#462 is against the branch associated to this PR for that reason 👍

@BenFradet BenFradet merged commit 439b411 into master Apr 15, 2020
@mergify mergify bot deleted the pagination branch April 15, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcsobral dcsobral dcsobral requested changes

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
breaking-change A breaking change that needs to be treated with consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenFradet @dcsobral @juanpedromoreno