Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn id fields into longs #523

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Turn id fields into longs #523

merged 2 commits into from
Jul 9, 2020

Conversation

chalenge
Copy link
Contributor

@chalenge chalenge commented Jun 30, 2020

Migrate all the id fields in github objects from int to use long. Solves an issue when the ids go over the max int such as 2170205650 which we saw as an id for the labels. I am not exactly sure of the ids are global to all repos but they do have really large numbers and hence decided to update all the other id fields for the client

Previous

final case class SomeGitObject(
  id: Int
  ....
)

Now

final case class SomeGitObject(
  id: Long
  ....
)

@chalenge chalenge closed this Jun 30, 2020
@chalenge
Copy link
Contributor Author

Will re-open this when I am fully done. Accidentally opened here instead of my fork 🤦

@chalenge chalenge reopened this Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #523 into master will decrease coverage by 11.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #523       +/-   ##
===========================================
- Coverage   90.45%   78.47%   -11.98%     
===========================================
  Files          24       24               
  Lines         618      618               
  Branches        1        1               
===========================================
- Hits          559      485       -74     
- Misses         59      133       +74     
Impacted Files Coverage Δ
...s/src/main/scala/github4s/domain/PullRequest.scala 0.00% <ø> (-100.00%) ⬇️
...4s/src/main/scala/github4s/domain/Repository.scala 100.00% <ø> (ø)
.../github4s/interpreters/ActivitiesInterpreter.scala 100.00% <ø> (ø)
...cala/github4s/interpreters/IssuesInterpreter.scala 100.00% <ø> (ø)
...la/github4s/interpreters/ProjectsInterpreter.scala 100.00% <ø> (ø)
...ithub4s/interpreters/PullRequestsInterpreter.scala 100.00% <ø> (ø)
...ithub4s/interpreters/RepositoriesInterpreter.scala 95.94% <ø> (ø)
github4s/src/main/scala/github4s/Decoders.scala 84.32% <100.00%> (-6.72%) ⬇️
github4s/src/main/scala/github4s/Github.scala 0.00% <0.00%> (-100.00%) ⬇️
...ithub4s/src/main/scala/github4s/GithubConfig.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11a930...b38b69f. Read the comment docs.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@BenFradet BenFradet changed the title Make all case object ids fields longs instead of ints Turn id fields into longs Jul 9, 2020
@BenFradet BenFradet merged commit 302168a into 47degrees:master Jul 9, 2020
@tovbinm tovbinm deleted the cm-make-ids-long branch July 10, 2020 20:36
@juanpedromoreno juanpedromoreno added the breaking-change A breaking change that needs to be treated with consideration label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change that needs to be treated with consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants