Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if user is a collaborator #530

Merged
merged 12 commits into from
Jul 23, 2020
Merged

Add check if user is a collaborator #530

merged 12 commits into from
Jul 23, 2020

Conversation

zachkirlew
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #530 into master will decrease coverage by 13.46%.
The diff coverage is 21.05%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #530       +/-   ##
===========================================
- Coverage   90.52%   77.06%   -13.47%     
===========================================
  Files          24       24               
  Lines         623      641       +18     
  Branches        1        1               
===========================================
- Hits          564      494       -70     
- Misses         59      147       +88     
Impacted Files Coverage Δ
...ub4s/src/main/scala/github4s/http/HttpClient.scala 12.12% <0.00%> (-75.38%) ⬇️
...ithub4s/interpreters/RepositoriesInterpreter.scala 90.80% <44.44%> (-5.35%) ⬇️
github4s/src/main/scala/github4s/Github.scala 0.00% <0.00%> (-100.00%) ⬇️
...ithub4s/src/main/scala/github4s/GithubConfig.scala 0.00% <0.00%> (-100.00%) ⬇️
...4s/src/main/scala/github4s/http/Http4sSyntax.scala 0.00% <0.00%> (-100.00%) ⬇️
...s/src/main/scala/github4s/domain/PullRequest.scala 0.00% <0.00%> (-100.00%) ⬇️
...s/src/main/scala/github4s/modules/GithubAPIs.scala 0.00% <0.00%> (-100.00%) ⬇️
.../src/main/scala/github4s/http/RequestBuilder.scala 0.00% <0.00%> (-100.00%) ⬇️
.../scala/github4s/interpreters/AuthInterpreter.scala 60.00% <0.00%> (-40.00%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6c894...6f49b1c. Read the comment docs.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , I just have a few minor comments.

microsite/docs/repository.md Outdated Show resolved Hide resolved
microsite/docs/repository.md Show resolved Hide resolved
@zachkirlew zachkirlew requested a review from cb372 July 22, 2020 08:00
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to run the tests locally I found the following issue: buildResponse relies on http4s' attemptAs which expects a non-empty body so we will always get a left.

@zachkirlew
Copy link
Contributor Author

zachkirlew commented Jul 22, 2020

Trying to run the tests locally I found the following issue: buildResponse relies on http4s' attemptAs which expects a non-empty body so we will always get a left.

buildResponse isn't called in HttpClient.getWithoutResponse which is the method used in userIsCollaborator?

@BenFradet
Copy link
Contributor

Trying to run the tests locally I found the following issue: buildResponse relies on http4s' attemptAs which expects a non-empty body so we will always get a left.

buildResponse isn't called in HttpClient.getWithoutResponse which is the method used in userIsCollaborator?

getWithoutResponse calls run which calls buildResponse.

To run the tests locally you need a GITHUB_TOKEN env var: https://47degrees.github.io/github4s/contributing#token

@zachkirlew
Copy link
Contributor Author

@BenFradet Tests fixed

@cb372
Copy link
Member

cb372 commented Jul 23, 2020

The tests were running for 45 minutes. I've just cancelled them and restarted 🤞

Copy link
Member

@cb372 cb372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@BenFradet BenFradet merged commit f125d6a into 47degrees:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants