ScalaDoc #9
Merged
ScalaDoc #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 0.69%@@ master #9 diff @@
========================================
Files 14 14
Lines 143 143
Methods 0 0
Messages 0 0
Branches 1 1
========================================
+ Hits 0 1 +1
+ Misses 143 142 -1
Partials 0 0
|
| * @param scopes attached to the token | ||
| * @param note to remind you what the OAuth token is for | ||
| * @param client_id the 20 character OAuth app client key for which to create the token | ||
| * @param client_secret the 40 character OAuth app client secret for which to create the token |
There was a problem hiding this comment.
Maybe we should include return type here
@return GHResponse[Authorization] comment
|
I think that we should use
|
|
|
@javipacheco Your comments have been addressed. I'm going to increase test coverage in next PRs, is good to merge so far? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes comments in order to generate Scala API Doc.
@javipacheco Could you take a look please?