Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home layout HighLighting #311

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Home layout HighLighting #311

merged 3 commits into from
Jun 11, 2019

Conversation

AntonioMateoGomez
Copy link
Contributor

This PR fixes #310

Adds cloudflare highlight scripts in the main footer

calvellido
calvellido requested changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@calvellido calvellido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid injecting jQuery, and/or Bootstrap, duplicated highlight JS scripts?

TL; DR: What would be the minimum script bloat needed to have the highlighting working?

calvellido
calvellido approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AntonioMateoGomez AntonioMateoGomez merged commit 9f9af6f into master Jun 11, 2019
@AntonioMateoGomez AntonioMateoGomez mentioned this pull request Jun 11, 2019
Closed
@AntonioMateoGomez AntonioMateoGomez deleted the paolo-310-code-highlighting branch June 19, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvellido calvellido calvellido approved these changes

@juanpedromoreno juanpedromoreno Awaiting requested review from juanpedromoreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code highlighting doesn't work in home layout
2 participants
@AntonioMateoGomez @calvellido