Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Search for Pattern Theme #547

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Conversation

sloshy
Copy link
Contributor

@sloshy sloshy commented Feb 1, 2021

Resolves #542

Enables search for the pattern theme! A lot of older microsites are still using this theme so it's good that search is available to it. I had some difficulty meshing the style of the light theme with the pattern theme, and it might look a bit visually inconsistent in some small areas, but I feel this is at least a good start.

Also removes the Google+ share-on-social link, as that service has been discontinued for some time. It also made it easier to adjust the CSS with it gone as there was more room to play with.

Pic examples of the search in pattern theme:
Screen Shot 2021-02-01 at 5 17 50 PM
Screen Shot 2021-02-01 at 5 18 58 PM

I made sure that the CSS changes here didn't override any previous visual settings, so the rest of the navbar links still have transparency on hover, docs navbar entries are still uppercase without affecting search results, etc.

@sloshy sloshy changed the title Feature/search pattern theme Enable Search for Pattern Theme Feb 1, 2021
@github-actions github-actions bot added the enhancement New feature or request label Feb 1, 2021
@calvellido calvellido self-requested a review February 2, 2021 08:27
@sloshy sloshy merged commit 283ccbc into master Feb 2, 2021
@sloshy sloshy deleted the feature/search-pattern-theme branch February 2, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Search for pattern theme
2 participants