-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UnauthorizedError on GitHub Enterprise publish #740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @necosta. Please, @TomyMeren, let me know if this fixes the issue.
After reading google/go-github#958, adjusted baseUrl logic. |
abc6978
to
0554c40
Compare
Added edge-case scenario for when micrositeGitHostingUrl is still pointing to public GitHub:
|
Good progress! @necosta. The current error is this:
It could be a problem with the method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @TomyMeren for testing. I did mess up the PR when I last updated, will get the changes from the "patched" branch, adjust the tests, then I think we are good to merge. Will do it now. |
When I publish the sbt-microsite project locally, for use in the project, version 1.4.1+1.....-SNAPSHOT is created. The latest release version is 1.4.2. Do you know why this is? |
Yes, publishLocal is configured to build a "SNAPSHOT" version and not a "release" version. It should work this way to avoid any version conflict. |
Green CI. It's ready for a final review @fedefernandez , feel free to merge after you approve the PR. Thank you @TomyMeren for testing it. |
Sorry for my unclear comment. |
Ah I see. I tried now, I do get 1.4.2-SNAPSHOT when publishing locally. Perhaps you are missing the git tag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes It was a missing tag
LGTM!
Green CI and all comments resolved. Is it ok to merge to master @fedefernandez ? thanks |
When
gitHostingURL
is set, we see the following error:We need to adjust GithubConfig base/authorize/accessToken URLs to contain the
gitHostingURL
host.@TomyMeren , can you: