Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalizing ZDT with granularity #213

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix normalizing ZDT with granularity #213

merged 1 commit into from
Feb 2, 2021

Conversation

sloshy
Copy link
Contributor

@sloshy sloshy commented Feb 2, 2021

For some reason it appears that ZDTs are not normalized properly, causing a failure in the test suite that has prevented automatic dependency updates and broken CI for about a month. This change ensures that normalizing ZDTs is applied appropriately.

@github-actions github-actions bot added the bug Something isn't working label Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #213 (7db13cc) into master (725007a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          10       10           
  Lines         139      139           
  Branches        0        2    +2     
=======================================
  Hits          134      134           
  Misses          5        5           
Impacted Files Coverage Δ
...rtysevendeg/scalacheck/datetime/jdk8/GenJdk8.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41092b...f1d988c. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @sloshy !

@sloshy sloshy merged commit f04604b into master Feb 2, 2021
@sloshy sloshy deleted the fix/zdt-granularity branch February 2, 2021 21:39
@sloshy sloshy added the breaking-change A breaking change that needs to be treated with consideration label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change that needs to be treated with consideration bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants