fix: localStorage availability check update #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iuriizaporozhets is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
franky47
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Thanks for this!
I see an issue with the current way it's implemented: if a client has a localStorage value under the test key, it would get cleared by what should otherwise be an idempotent function.
One alternative would be to read the value before attempting a write, and restore it at the end, or use a more specifically-named key, which won't cause collisions.
fix: formatting and naming fixes
|
🎉 This PR is included in version 1.17.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in Safari set Block All cookies then local storage also will not work. But window.localStorage object itself will be available and when we will try set or get something from local storage we will get
SecurityError: The operation is insecure.error and it is crashing the application for users with disabled cookies and local storage.