feat: Abstract reading from location.search in adapters interface #800
+34
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
This is mainly for the testing adapter to only work on the provided set of initial search params without needing to stub/mock location.search. But it also opens the door for adapters to define new storage locations, like hash/fragment or even localStorage.
franky47
force-pushed
the
feat/abstract-location-search-in-adapters
branch
from
0a61c35 to
0621948
Compare
This was referenced Dec 12, 2024
Closed
|
🎉 This PR is included in version 2.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly for the testing adapter to only work on the provided set of initial search params without needing to stub/mock location.search.
But it also opens the door for adapters to define new storage locations, like hash/fragment or even localStorage.
Note: might be useful for #723 and #206.