Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mode=strict throws when plaintext in database #107

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: mode=strict throws when plaintext in database #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/encryption.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ export function decryptOnRead<Models extends string, Actions extends string>(
}) {
try {
if (!cloakedStringRegex.test(cipherText)) {
if (fieldConfig.strictDecryption) {
throw new Error('Value is not encrypted and mode=strict')
Copy link
Member

@franky47 franky47 Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Could you move the error message to the errors.ts file, to add some context (model/field) please? Having this in logs helps a lot debugging those kind of errors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be wrapped in the FieldDecryptionError in the catch?

}
return
}
const decryptionKey = findKeyForMessage(cipherText, keys.keychain)
Expand Down