Handle file protocol on initialisation #38
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to bundle my found-relay (modern) react app into an electron distributable, I realised that the routing wouldn't work on first load as the pathname would be something like
/home/jtfell/project/dist/index.html
when I really wanted to start at/
.This change seems to have fixed that, with all subsequent internal links working as relative paths. I'm not at all sure if this is the best approach to handle all the edge-cases surrounding the file protocol but it works for me.
One issue I ran into is that making the change here causes it not to be triggered when the page is refreshed. Do you have any ideas on a better place to slot this in @taion? Even if you don't want to merge this it would be great to get your thoughts.