Skip to content

Commit

Permalink
Bugfix/ci lint proguard (facebook#19724)
Browse files Browse the repository at this point in the history
Summary:
* avoid lint to interrupt ci
* add proguard rules
pass all ci
none
 [GENERAL] [ENHANCEMENT] [CI] - Fix lint and proguard
Closes facebook#19724

Differential Revision: D8446721

Pulled By: hramos

fbshipit-source-id: b21c5418210b27dda6a7194995a25df39af0c92a
  • Loading branch information
gengjiawen authored and facebook-github-bot committed Jun 15, 2018
1 parent 5fd5e6b commit 86d8c7a
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
5 changes: 5 additions & 0 deletions RNTester/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ android {
signingConfig signingConfigs.release
}
}

lintOptions {
abortOnError false
}

// applicationVariants are e.g. debug, release
applicationVariants.all { variant ->
variant.outputs.each { output ->
Expand Down
8 changes: 8 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,12 @@ allprojects {
url "$androidSdk/extras/m2repository/"
}
}

project.configurations.all {
resolutionStrategy.eachDependency { details ->
if (details.requested.group == 'com.facebook.soloader') {
details.useVersion "0.3.0"
}
}
}
}

0 comments on commit 86d8c7a

Please sign in to comment.