-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix coverage files upload by enable hidden files upload #1186
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
WalkthroughThe change introduces a new parameter, Changes
Assessment against linked issues
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/base_test_workflow.yml (1 hunks)
Additional context used
actionlint
.github/workflows/base_test_workflow.yml
112-112: input "include-hidden-files" is not defined in action "actions/upload-artifact@v4". available inputs are "compression-level", "if-no-files-found", "name", "overwrite", "path", "retention-days"
(action)
Additional comments not posted (1)
.github/workflows/base_test_workflow.yml (1)
112-112
: LGTM!The change to include hidden files in the coverage report uploads looks good after fixing the parameter name.
This will ensure that the coverage files, which may be hidden, are included in the uploads, aligning with the PR objective.
Tools
actionlint
112-112: input "include-hidden-files" is not defined in action "actions/upload-artifact@v4". available inputs are "compression-level", "if-no-files-found", "name", "overwrite", "path", "retention-days"
(action)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1186 +/- ##
============================================
+ Coverage 0 93.10% +93.10%
============================================
Files 0 209 +209
Lines 0 32895 +32895
============================================
+ Hits 0 30627 +30627
- Misses 0 2268 +2268 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/base_test_workflow.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/base_test_workflow.yml
fix bug introduced by actions/upload-artifact#602
Summary by CodeRabbit