Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix coverage files upload by enable hidden files upload #1186

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Sep 3, 2024

fix bug introduced by actions/upload-artifact#602

Summary by CodeRabbit

  • New Features
    • Introduced a new parameter to include hidden files in coverage reports, enhancing the comprehensiveness of the analysis.

@Czaki Czaki added this to the 0.15.4 milestone Sep 3, 2024
Copy link
Contributor

sourcery-ai bot commented Sep 3, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

coderabbitai bot commented Sep 3, 2024

Walkthrough

The change introduces a new parameter, include-hidden-files, in the GitHub Actions workflow, allowing hidden files to be included in coverage reports. This modification enhances the coverage reporting process by ensuring that all relevant files, including hidden ones, are considered during the assessment.

Changes

File Change Summary
.github/workflows/base_test_workflow.yml Added parameter include-hidden-files: 'true' to include hidden files in coverage reports.

Assessment against linked issues

Objective Addressed Explanation
Hidden files will be excluded by default (602)
Option to include hidden files in uploads (602)

🐰 In the meadow, I hop with glee,
Hidden files now join the spree!
Coverage reports, oh what a sight,
All files included, feels so right!
Let's celebrate this change today,
Hooray for hidden files, hip-hip-hooray! 🌼

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Czaki Czaki changed the title Fix coverage files upload by enable hidden files upload chore: Fix coverage files upload by enable hidden files upload Sep 3, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7a66801 and 7dd3a3a.

Files selected for processing (1)
  • .github/workflows/base_test_workflow.yml (1 hunks)
Additional context used
actionlint
.github/workflows/base_test_workflow.yml

112-112: input "include-hidden-files" is not defined in action "actions/upload-artifact@v4". available inputs are "compression-level", "if-no-files-found", "name", "overwrite", "path", "retention-days"

(action)

Additional comments not posted (1)
.github/workflows/base_test_workflow.yml (1)

112-112: LGTM!

The change to include hidden files in the coverage report uploads looks good after fixing the parameter name.

This will ensure that the coverage files, which may be hidden, are included in the uploads, aligning with the PR objective.

Tools
actionlint

112-112: input "include-hidden-files" is not defined in action "actions/upload-artifact@v4". available inputs are "compression-level", "if-no-files-found", "name", "overwrite", "path", "retention-days"

(action)

.github/workflows/base_test_workflow.yml Show resolved Hide resolved
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (7a66801) to head (a6ee1c5).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1186       +/-   ##
============================================
+ Coverage         0   93.10%   +93.10%     
============================================
  Files            0      209      +209     
  Lines            0    32895    +32895     
============================================
+ Hits             0    30627    +30627     
- Misses           0     2268     +2268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 3, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7dd3a3a and a6ee1c5.

Files selected for processing (1)
  • .github/workflows/base_test_workflow.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/base_test_workflow.yml

@Czaki Czaki merged commit 7e0063f into develop Sep 3, 2024
56 of 57 checks passed
@Czaki Czaki deleted the fix_coverage branch September 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant