Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export missing scope parameter issue #89

Closed
wants to merge 79 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
6a8e20c
[DSC-1352] Move breadcrumb char limit property inside layout configur…
davide-negretti Nov 22, 2023
b513c55
[DSC-1408] - Fix dropdown readonly field
NikitaKr1vonosov Nov 30, 2023
4724dfc
Prepare next development iteration
atarix83 Nov 30, 2023
e6a7165
Merged dspace-cris-7 into DSC-1408
Dec 5, 2023
358ee7c
Merged in DSC-1408 (pull request #1069)
NikitaKr1vonosov Dec 5, 2023
2eaf3d8
Merge branch 'dspace-cris-7' into DSC-1352
Dec 5, 2023
6b657f5
Merged in DSC-1352 (pull request #1046)
Dec 5, 2023
fb31da7
[DSC-1037] Adds semicolon to author-list
vins01-4science Dec 7, 2023
f5d618f
Merged in DSC-1037 (pull request #1094)
vins01-4science Dec 11, 2023
4812f18
Merged in dspace-cris-DSC-1430 (pull request #1100)
atarix83 Dec 11, 2023
bb002aa
[DSC-1434] feature: update twitter to x button
vNovski Dec 18, 2023
4540186
[DSC-1434] fix configuration issue ('link' property removed)
davide-negretti Dec 21, 2023
dc07471
Merged in DSC-1434-update-twitter-button (pull request #1128)
vNovski Dec 21, 2023
4f03340
[DSC-1108] added unit tests on collection/community page
alisaismailati Dec 27, 2023
3456285
ensure HALEndpointService doesn't use stale requests
artlowel Nov 29, 2023
ca56af6
also skip loading hal requests
artlowel Dec 1, 2023
18190c8
add ResponsePendingStale state
artlowel Dec 6, 2023
4618660
[DSC-1066] search-filter query with [ ]
alisaismailati Jan 4, 2024
f9ea929
[DSC-1073] specify the communityorCollection discovery configuration …
alisaismailati Jan 4, 2024
f9ca961
Merge tag 'dspace-cris-2023.02.01' into dspace-cris-7
abollini Jan 6, 2024
8943e85
Target the development branch to the next 2024.01.00 release
abollini Jan 6, 2024
40b41c6
Merge branch 'dspace-cris-2023_02_x-DSC-1438' into dspacecris-7-DSC-1438
atarix83 Jan 9, 2024
7751db9
Merged in dspacecris-7-DSC-1438 (pull request #1190)
atarix83 Jan 9, 2024
d8949ee
[DSC-1477] Rename branch in pipeline settings
atarix83 Jan 11, 2024
efe6a5b
[DSC-1477] Rename branch in references
atarix83 Jan 11, 2024
1b7438a
Merge branch 'main-cris' into DSC-1066
alisaismailati Jan 12, 2024
fea8c82
Merge branch 'main-cris' into DSC-1073
alisaismailati Jan 12, 2024
77aa8c5
[DSC-1456] feature: filters visible in the search sidebar
vNovski Jan 12, 2024
e340961
[DSC-1485] feature: csv and xls metadata export find any community
vNovski Jan 15, 2024
2611be1
Merge remote-tracking branch 'origin/main-cris' into DSC-1485-csv-and…
vNovski Jan 15, 2024
ce50f1a
Merge remote-tracking branch 'origin/main-cris' into DSC-1456-filters…
vNovski Jan 15, 2024
00b636f
Merge branch 'dspace-cris-2023_02_x' into DSC-1456-filters-are-no-lon…
atarix83 Jan 15, 2024
3f358f9
Merged in DSC-1456-filters-are-no-longer-visible-in-the-search-sideba…
vNovski Jan 15, 2024
df1700b
Merge remote-tracking branch '4sciencebitbucket/dspace-cris-2023_02_x…
atarix83 Jan 15, 2024
0987c3e
Merged main-cris into DSC-1485-csv-and-xls-metadata-export
atarix83 Jan 15, 2024
49ab676
Merged in DSC-1485-csv-and-xls-metadata-export (pull request #1219)
vNovski Jan 15, 2024
ba93b16
Merge branch 'main-cris' into DSC-1108-II
alisaismailati Jan 16, 2024
e3ff3f8
[CST-7675] added default file thumbnail
steph-ieffam Nov 10, 2023
8c24a3d
[DSC-1383] Fix metrics layout and responsivity
davide-negretti Jan 16, 2024
3363c67
Merged main-cris into DSC-1383-davide
Jan 16, 2024
4d707bf
Merged in DSC-1383-davide (pull request #1224)
Jan 16, 2024
215a05a
[DSC-1484] feature: added utility functions
vNovski Jan 16, 2024
eb929b9
[DSC-1484] feature: added internal link service
vNovski Jan 17, 2024
4a73c5a
[DSC-1484] changed commit for functions
vNovski Jan 19, 2024
08f3a93
Merged in DSC-1484-create-utility-functions (pull request #1241)
vNovski Jan 19, 2024
054d05e
Merged main-cris into DSC-1446-main
steph-ieffam Jan 19, 2024
df4661f
Merged in DSC-1108-II (pull request #1229)
alisaismailati Jan 19, 2024
7a5f6f1
Merged in DSC-1073 (pull request #1206)
alisaismailati Jan 19, 2024
d297577
Merge branch 'dspace-cris-2023_02_x' into main-cris-DSC-1489
atarix83 Jan 23, 2024
c177d3b
Merged in main-cris-DSC-1489 (pull request #1260)
atarix83 Jan 23, 2024
4e826d9
[DSC-1484] fix: unit-tests
vNovski Jan 26, 2024
4cd3982
Merged in DSC-1484-create-utility-functions-main (pull request #1275)
vNovski Jan 26, 2024
0a02da1
Merged in DSC-1446-main (pull request #1228)
alisaismailati Jan 26, 2024
ee469e2
Merge remote-tracking branch 'origin/dspace-cris-2023_02_x' into item…
FrancescoMolinaro Jan 26, 2024
974029f
Merged in item_mapper_main_DSC_1073 (pull request #1279)
FrancescoMolinaro Jan 26, 2024
4c2d08c
Merged in DSC-1066 (pull request #1205)
alisaismailati Jan 26, 2024
4f32f00
add source integration
FrancescoMolinaro Jan 30, 2024
35722fd
add source image mapping, handle error, style onebox component
FrancescoMolinaro Jan 31, 2024
9188189
DSC-1498: update source labels
FrancescoMolinaro Feb 1, 2024
02d4e04
Merge remote-tracking branch 'origin/dspace-cris-2023_02_x' into DSC-…
vNovski Feb 6, 2024
48b8f4b
Merged in DSC-1387-export-menu-in-person-entity-main-cris (pull reque…
vNovski Feb 6, 2024
f2846eb
Merge branch 'dspace-cris-2023_02_x' into DSC-983-counters-component-…
davide-negretti Feb 6, 2024
c1c5a66
Merged in DSC-983-counters-component-main (pull request #1318)
Feb 6, 2024
359ddec
Merge branch 'dspace-cris-2023_02_x' into main-cris
atarix83 Feb 6, 2024
b58ed3d
DSC-1489 update mapped icon and labels
FrancescoMolinaro Feb 2, 2024
52a4212
Merge branch 'dspace-cris-2023_02_x' into gdpr-metrics-DSC-1522
FrancescoMolinaro Feb 8, 2024
2e532e8
[DSC-1498] configured label for Sherpa Romeo source in authority drop…
steph-ieffam Feb 8, 2024
850554f
fix tests
FrancescoMolinaro Feb 8, 2024
e2cec01
DSC-1498 add sherpa logo
FrancescoMolinaro Feb 8, 2024
0d2b3d4
Merged in gdpr-metrics-DSC-1522 (pull request #1326)
FrancescoMolinaro Feb 9, 2024
8249d00
Merge branch 'dspace-cris-2023_02_x' into main-cris
atarix83 Feb 9, 2024
e4e9193
Merged in authority_source_2023_02_x_DSC_1498 (pull request #1299)
FrancescoMolinaro Feb 12, 2024
00aa481
Merge branch 'dspace-cris-2023_02_x' into main-cris
atarix83 Feb 22, 2024
021eb43
Merge branch 'dspace-cris-2023_02_x' into main-cris
atarix83 Feb 28, 2024
e270018
Merge branch 'dspace-cris-2023_02_x' into main-cris
atarix83 Mar 22, 2024
53fc9e1
Merge branch 'dspace-cris-2023_02_x' into main-cris
atarix83 Mar 29, 2024
8a37ae7
Fix missing scope parameter issue
oye816 Apr 30, 2024
bd1da6b
Remove Trailing spaces
oye816 Apr 30, 2024
97c09a6
Merge branch 'dspace-cris-2023_02_x' into export_issue
oye816 May 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitbucket-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ definitions:

pipelines:
branches:
'dspace-cris-2023_02_x':
'main-cris':
- step: *unittest-code-checks
pull-requests:
'**':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class TruncateBreadcrumbItemCharactersPipe implements PipeTransform {
* The maximum number of characters to display in a breadcrumb item
* @type {number}
*/
readonly charLimit: number = environment.breadcrumbCharLimit;
readonly charLimit: number = environment.layout.breadcrumbs.charLimit;

/**
* Truncates the text based on the configured char number allowed per breadcrumb element.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ export function normalizeSectionData(obj: any, objIndex?: number) {
(obj.display || obj.value),
obj.place || objIndex,
obj.confidence,
obj.otherInformation
obj.otherInformation,
obj.source
);
} else if (Array.isArray(obj)) {
result = [];
Expand Down
2 changes: 1 addition & 1 deletion src/app/footer/footer.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h5 class="text-uppercase">Get Involved!</h5>

<ul class="list-unstyled mb-0">
<li>
<a href="https://github.com/4Science/DSpace/tree/dspace-cris-7">
<a href="https://github.com/4Science/DSpace/tree/main-cris">
<i class="fab fa-github" aria-hidden="true"></i> Source Code</a>
</li>
<li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@

<ng-template #hasInfo let-entry="entry">
<ul class="list-unstyled mb-0">
<li class="list-item text-truncate text-primary font-weight-bold">{{entry.value}}</li>
<li class="list-item d-flex align-items-center">
<div *ngIf="entry.source" class="mr-2">
<img onerror="handleImgError(this)" [src]="'assets/images/' + entry.source + '.logo.icon.svg'" [attr.alt]="('form.entry.source.' + entry.source) | translate" />
</div>
<div class="text-truncate text-primary font-weight-bold">{{entry.value}}</div>
<div *ngIf="entry.source" class="ml-2 text-truncate text-secondary">{{ ('form.entry.source.' + entry.source) | translate}}</div>
</li>
<ng-container *ngFor="let item of entry.otherInformation | dsObjNgFor">
<li *ngIf="!item.key.startsWith('data-')" class="list-item text-truncate text-secondary" >
{{ 'form.other-information.' + item.key | translate }} : {{item.value !== '' ? getOtherInfoValue(item.value, item.key) : ('form.other-information.not-available' | translate)}}
Expand All @@ -18,7 +24,13 @@

<ng-template #noInfo let-entry="entry">
<ul class="list-unstyled mb-0">
<li class="list-item text-truncate text-primary font-weight-bold">{{entry.value}}</li>
<li class="list-item d-flex align-items-center">
<div *ngIf="entry.source" class="mr-2">
<img onerror="handleImgError(this)" [src]="'assets/images/' + entry.source + '.logo.icon.svg'" [attr.alt]="('form.entry.source.' + entry.source) | translate" />
</div>
<div class="text-truncate text-primary font-weight-bold">{{entry.value}}</div>
<div *ngIf="entry.source" class="ml-2 text-truncate text-secondary">{{ ('form.entry.source.' + entry.source) | translate}}</div>
</li>
</ul>
</ng-template>

Expand Down
2 changes: 2 additions & 0 deletions src/app/shared/form/builder/form-builder.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ export class FormBuilderService extends DynamicFormService {
(controlModel as any).metadataValue.place,
(controlModel as any).metadataValue.confidence,
(controlModel as any).metadataValue.otherInformation,
(controlModel as any).metadataValue.source,
(controlModel as any).metadataValue.metadata);
}

Expand All @@ -277,6 +278,7 @@ export class FormBuilderService extends DynamicFormService {
(controlModel as any).value.place,
(controlModel as any).value.confidence,
(controlModel as any).value.otherInformation,
(controlModel as any).value.source,
(controlModel as any).value.metadata);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class FormFieldMetadataValueObject implements MetadataValueInterface {
place: number;
label: string;
securityLevel: number;
source: string;
otherInformation: OtherInformation;

constructor(value: any = null,
Expand All @@ -35,7 +36,9 @@ export class FormFieldMetadataValueObject implements MetadataValueInterface {
place: number = 0,
confidence: number = null,
otherInformation: any = null,
metadata: string = null) {
source: string = null,
metadata: string = null
) {
this.value = isNotNull(value) ? ((typeof value === 'string') ? value.trim() : value) : null;
this.language = language;
this.authority = authority;
Expand All @@ -54,7 +57,7 @@ export class FormFieldMetadataValueObject implements MetadataValueInterface {
if (isNotEmpty(metadata)) {
this.metadata = metadata;
}

this.source = source;
this.otherInformation = otherInformation;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ describe('MetricAltmetricComponent', () => {
component = fixture.componentInstance;
component.metric = metricMock;
component.success = true;
component.canLoadScript = true;
component.maxRetry = 0;
fixture.detectChanges();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ describe('MetricDimensionsComponent', () => {
component = fixture.componentInstance;
component.metric = metricMock;
component.success = true;
component.canLoadScript = true;
component.maxRetry = 0;
fixture.detectChanges();
});
Expand Down
13 changes: 13 additions & 0 deletions src/app/shared/search/item-export/item-export.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,17 @@ export class ItemExportService {
};
}

/**
* Get the UUID from a searchOptions
* @param searchOptions
*/
public getScopeUUID(searchOptions: SearchOptions): string {
if (searchOptions.fixedFilter) {
const fixedFilter = searchOptions.fixedFilter.split('=');
if (fixedFilter.length === 2 && fixedFilter[0] === 'scope') {
return fixedFilter[1];
}
}
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import { fadeIn } from '../../../../animations/fade';
import { PaginatedSearchOptions } from '../../../models/paginated-search-options.model';
import { UUIDService } from '../../../../../core/shared/uuid.service';

import { ItemExportService } from '../../item-export.service';

@Component({
selector: 'ds-item-export-list',
templateUrl: './item-export-list.component.html',
Expand Down Expand Up @@ -64,6 +66,7 @@ export class ItemExportListComponent implements OnInit {
resultsRD$: BehaviorSubject<RemoteData<SearchObjects<DSpaceObject>>> = new BehaviorSubject(null);

constructor(
protected itemExportService: ItemExportService,
private paginationService: PaginationService,
private searchManager: SearchManager,
private uuidService: UUIDService) {
Expand All @@ -74,6 +77,7 @@ export class ItemExportListComponent implements OnInit {
this.currentPagination$ = this.paginationService.getCurrentPagination(this.initialPagination.id, this.initialPagination);
this.currentPagination$.subscribe((paginationOptions: PaginationComponentOptions) => {
this.searchOptions = Object.assign(new PaginatedSearchOptions({}), this.searchOptions, {
scope: this.itemExportService.getScopeUUID(this.searchOptions),
fixedFilter: `f.entityType=${this.itemEntityType},equals`,
pagination: paginationOptions
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ export class ItemExportComponent implements OnInit, OnDestroy {
private canExport(): Observable<boolean> {
return this.searchManager.search(
Object.assign(new PaginatedSearchOptions({}), this.searchOptions, {
scope: this.itemExportService.getScopeUUID(this.searchOptions),
fixedFilter: `f.entityType=${this.itemType.label},equals`,
pagination: Object.assign(new PaginationComponentOptions(), {
id: this.uuidService.generate(),
Expand Down
12 changes: 12 additions & 0 deletions src/assets/i18n/en.json5
Original file line number Diff line number Diff line change
Expand Up @@ -2471,6 +2471,18 @@

"form.other-information.ror_orgunit_acronym": "ROR acronym",

"form.entry.source.local": "",

"form.entry.source.orcid": "",

"form.entry.source.ror": "",

"form.entry.source.openaire": "",

"form.entry.source.zdb": "",

"form.entry.source.sherpa": "- Sherpa Romeo",

"form.remove": "Remove",

"form.save": "Save",
Expand Down
1 change: 1 addition & 0 deletions src/assets/images/local.logo.icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/assets/images/openaire.logo.icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions src/assets/images/ror.logo.icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
41 changes: 41 additions & 0 deletions src/assets/images/sherpa.logo.icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/assets/images/zdb.logo.icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading