initialize ranges with max_range rather than zero #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
situation before:
cob_sick_s300
driver publishes some ranges as29.959999084472656
- most likely due to reflections e.g. from railings or glass frontscob_scan_unifer
- because they are>max_range
(max_range=29.5)unified_scan.ranges
are initialized with0.0
scan_unified
will have a range of0.0
which later gets removed duringlaser_zone_filter
resulting in "holes" in the scansituation now:
max_range
this significantly reduces "trails" in the costmap for the scan unified obstacle layer
I already verified the behavior on
cob4-22
in 25h köln....and it looks much bettercontributes to https://github.com/mojin-robotics/cob4/issues/888#issuecomment-439805060