Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize ranges with max_range rather than zero #385

Merged

Conversation

fmessmer
Copy link
Contributor

situation before:

  • cob_sick_s300 driver publishes some ranges as 29.959999084472656 - most likely due to reflections e.g. from railings or glass fronts
  • these data points are removed during the projection in cob_scan_unifer - because they are >max_range (max_range=29.5)
  • the unified_scan.ranges are initialized with 0.0
  • for those data points removed during projection, scan_unified will have a range of 0.0 which later gets removed during laser_zone_filter resulting in "holes" in the scan
  • along the rays within those "holes" the costmap cannot clear the obstacle layer

situation now:

  • now scan_unifier behaves as the driver: fake data points are set to max_range

this significantly reduces "trails" in the costmap for the scan unified obstacle layer

I already verified the behavior on cob4-22 in 25h köln....and it looks much better

contributes to https://github.com/mojin-robotics/cob4/issues/888#issuecomment-439805060

Copy link
Contributor

@HannesBachter HannesBachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment (in the code) on why you changed the default distance to max_range in order to avoid confusion in a future investigation

@fmessmer fmessmer merged commit dc84b0b into 4am-robotics:indigo_dev Nov 22, 2018
@fmessmer fmessmer deleted the scan_unifier_range_initialization branch November 22, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants