refactor(SPV-1192): replace query params by page filter. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Testsℹ️ Remember to ask team members to perform manual tests and to assign |
dzolt-4chain
approved these changes
Nov 14, 2024
… validation in the transaction API.
wregulski
approved these changes
Nov 14, 2024
mgosek-4chain
deleted the
refactor/SPV-1192-replace-query-params-by-page-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation introduces an updated method for setting pagination and sorting query parameters, such as
pageSize,sort, andsortBy. This replaces the previous approach, which was tied to deprecated endpoints (those lacking the /api/v1 prefix).Additionally, this update addresses an issue with validating transaction response page details. The previous implementation of the transactions API returned only the direct content of the API response page. This limited the ability to validate important information, such as the source of the returned transactions. The current implementation now ensures that all necessary response details are included, enabling proper validation.
Pull Request Checklist