forked from bitcoin-sv/spv-wallet-go-client
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(SPV-1213): Admin API access with user xpubs implementation. #20
Merged
mgosek-4chain
merged 13 commits into
main
from
refactor/SPV-1213-admin-api-access-with-user-xpubs-implementation
Nov 27, 2024
Merged
refactor(SPV-1213): Admin API access with user xpubs implementation. #20
mgosek-4chain
merged 13 commits into
main
from
refactor/SPV-1213-admin-api-access-with-user-xpubs-implementation
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Testsℹ️ Remember to ask team members to perform manual tests and to assign |
mgosek-4chain
changed the title
Refactor/spv 1213 admin api access with user xpubs implementation
(refactor:SPV-1213): Admin API access with user xpubs implementation.
Nov 22, 2024
mgosek-4chain
changed the title
(refactor:SPV-1213): Admin API access with user xpubs implementation.
refactor:(SPV-1213): Admin API access with user xpubs implementation.
Nov 22, 2024
mgosek-4chain
changed the title
refactor:(SPV-1213): Admin API access with user xpubs implementation.
refactor(SPV-1213): Admin API access with user xpubs implementation.
Nov 22, 2024
dorzepowski
requested changes
Nov 26, 2024
…te docs, update given spv admin API test helper.
dzolt-4chain
approved these changes
Nov 26, 2024
chris-4chain
approved these changes
Nov 26, 2024
dorzepowski
approved these changes
Nov 27, 2024
mgosek-4chain
deleted the
refactor/SPV-1213-admin-api-access-with-user-xpubs-implementation
branch
November 27, 2024 10:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the foundation for the Admin API HTTP client, which can be further extended to implement additional missing endpoints.
Major Changes
1. Package Renaming and Separation of Concerns
NewAdminAPIWithXPriv
,NewAdminAPIWithXPub
,NewUserAPIWithAccessKey
,NewUserAPIWithXPriv
,NewUserAPIWithXPub
2. Error Handling Enhancements
HTTPErrorFormatter
within theerrutil
package to standardize error messages and enable consistent wrapping of errors after unsuccessful API calls.Example error message format after API error call:
3. HTTP Client Setup Refactoring
resty
HTTP client setup into an internal package to align with the design agreement of consolidating internal implementation details in one place.This refactoring improves code organization, error handling consistency, and adheres to agreed-upon design principles.
Pull Request Checklist
Important
Before running the implementation with a manual example, ensure that the SPV Wallet API is running locally in your environment.
Example testing code snippet: