Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SPV-1230): admin endpoints group - Contacts API. #23

Merged
merged 11 commits into from
Dec 4, 2024
Merged

refactor(SPV-1230): admin endpoints group - Contacts API. #23

merged 11 commits into from
Dec 4, 2024

Conversation

mgosek-4chain
Copy link

@mgosek-4chain mgosek-4chain commented Nov 28, 2024 •
edited
Loading

Major Changes:

Admin API Enhancements:

  • Implemented support for the contacts and invitations Admin API endpoints, complete with detailed documentation.

Error Handling Improvements:

  • Added test cases to handle HTTP 500 status code responses from the SPV Wallet API, ensuring proper mapping to SPVError models.

Documentation and Examples Updates:

  • Updated code examples, the examples README, and the Taskfile to reflect the latest changes and improvements.

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@mgosek-4chain
refactor(SPV-1230): add draft implementation for contact, invitation …
f1b5886 
…APIs. Update documentation. Rename users dir to xpubs in api/v1/admin.
@github-actions GitHub Actions
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@mgosek-4chain mgosek-4chain changed the title refactor(SPV-1230): add draft implementation for contact, invitation … refactor(SPV-1230): admin endpoints group - Contacts API. Nov 28, 2024
@mgosek-4chain mgosek-4chain marked this pull request as ready for review November 29, 2024 13:41
jakubmkowalski
jakubmkowalski approved these changes Dec 4, 2024
View reviewed changes
admin_api.go Show resolved Hide resolved
@mgosek-4chain mgosek-4chain merged commit 83cb51d into main Dec 4, 2024
8 checks passed
@mgosek-4chain mgosek-4chain deleted the refactor/SPV-1230-admin-contacts-api-implementation branch December 4, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubmkowalski jakubmkowalski jakubmkowalski approved these changes

@dorzepowski dorzepowski dorzepowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgosek-4chain @dorzepowski @jakubmkowalski