Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SPV-1216): remove status codes - PR improvements. #26

Merged
merged 1 commit into from
Nov 29, 2024
Merged

refactor(SPV-1216): remove status codes - PR improvements. #26

merged 1 commit into from
Nov 29, 2024

Conversation

mgosek-4chain
Copy link

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@github-actions GitHub Actions
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@mgosek-4chain mgosek-4chain mentioned this pull request Nov 29, 2024
Merged
7 tasks
@mgosek-4chain mgosek-4chain changed the base branch from main to refactor/SPV-1216/Fix_unit_tests_status_codes November 29, 2024 12:05
@ac4ch ac4ch merged commit ea280af into refactor/SPV-1216/Fix_unit_tests_status_codes Nov 29, 2024
8 of 9 checks passed
@ac4ch ac4ch deleted the refactor/SPV-1216/Fix_unit_tests_status_codes_err_check_improvement branch November 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac4ch ac4ch ac4ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgosek-4chain @ac4ch