Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SPV-1231): admin endpoints group - Paymails API. #28

Merged

Conversation

mgosek-4chain
Copy link

@mgosek-4chain mgosek-4chain commented Dec 2, 2024

Major Changes:

Admin API Enhancements:

  • Implemented support for the paymails Admin API endpoints, complete with detailed documentation.

Documentation and Examples Updates:

  • Updated code examples, the examples README, and the Taskfile to reflect the latest changes and improvements.

How to test 🤔

  1. Go to examples dir cd examples
  2. Set XPriv in examples_keys.go file.
  3. Run the following commands in any order 😄:
  • task create-paymail-as-admin
  • task delete-paymail-as-admin
  • task fetch-paymail-as-admin
  • task fetch-paymails-as-admin

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented Dec 2, 2024

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@mgosek-4chain mgosek-4chain force-pushed the refactor/SPV-1231-admin-paymails-api-implementation branch from f571cf6 to 197833d Compare December 3, 2024 06:25
admin_api.go Outdated Show resolved Hide resolved
admin_api.go Show resolved Hide resolved
commands/paymails.go Show resolved Hide resolved
examples/exampleutil/exampleutil.go Show resolved Hide resolved
@mgosek-4chain mgosek-4chain merged commit 7e183e1 into main Dec 6, 2024
8 checks passed
@mgosek-4chain mgosek-4chain deleted the refactor/SPV-1231-admin-paymails-api-implementation branch December 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants