Fix #300 by sorting output targets before uploading #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified
awsf3/utils.py
by adding a sorting step based on mtime before uploading the created target files. Previously, the files were uploaded in arbitrary order, which created some issues with workflow managers (like snakemake) that rely on the mtime to decide if a file need to be recomputed.This commit can be tested using the following docker image:
nigiord/tibanna-awsf:1.2.8-fd40332
(awsf_image
option at job submission)Merging this should allow to close issue #300.