Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #300 by sorting output targets before uploading #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nigiord
Copy link

@nigiord nigiord commented May 21, 2021

I modified awsf3/utils.py by adding a sorting step based on mtime before uploading the created target files. Previously, the files were uploaded in arbitrary order, which created some issues with workflow managers (like snakemake) that rely on the mtime to decide if a file need to be recomputed.

This commit can be tested using the following docker image: nigiord/tibanna-awsf:1.2.8-fd40332 (awsf_image option at job submission)

Merging this should allow to close issue #300.

@nigiord
Copy link
Author

nigiord commented Feb 14, 2022

I synced the fork with the current version of Tibanna as it was getting quite old. Still no conflict with base branch as it simply adds a sorting step before uploading.

At this point I'm not sure this will be merged one day in master, but people who encounter the same issue and would like to use this workaround just have to use awsf_image=nigiord/tibanna-awsf:1.8.1-16cb036c in tibanna config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant