Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip prevent highlight if outside of canvas #6092

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ClementPasteau
Copy link
Collaborator

Attempt at fixing #6067

It solves the fact that items are still highlighted when mouse is outside of the canvas, but not the fact that it gets highlighted on the frame it is deleted.

renderedInstance._pixiObject.addEventListener('mouseover', event => {
console.log('mouseover', event);
if (
shouldPreventRenderingInstanceEditors() ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's reasonable to check on each frame if there's dialog open (DOM query). I think it should at least be cached for the current frame.

@DOCTYPEmike

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants