Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trino in pom.xml and add a util for print resultset #254

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

zekai427
Copy link
Contributor

@zekai427 zekai427 commented Aug 13, 2021

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Resolve #253 .

@zekai427 zekai427 linked an issue Aug 13, 2021 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

Linux Test Report

     47 files  ±0     119 suites  ±0   32m 53s ⏱️ ±0s
7 508 tests ±0  7 508 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8242cb6. ± Comparison against base commit 8242cb6.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #254 (47c6d55) into main (e4bbcee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #254   +/-   ##
=========================================
  Coverage     81.63%   81.63%           
  Complexity       13       13           
=========================================
  Files           283      283           
  Lines         50128    50128           
  Branches         29       29           
=========================================
  Hits          40924    40924           
  Misses         9195     9195           
  Partials          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bbcee...47c6d55. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

HybridSE Linux Test Report

       71 files  ±0       219 suites  ±0   5m 50s ⏱️ ±0s
17 665 tests ±0  17 665 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
17 672 runs  ±0  17 672 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8242cb6. ± Comparison against base commit 8242cb6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

HybridSE Mac Test Report

       71 files  ±0       219 suites  ±0   5m 22s ⏱️ ±0s
17 665 tests ±0  17 665 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
17 672 runs  ±0  17 672 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8242cb6. ± Comparison against base commit 8242cb6.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 8242cb6 into 4paradigm:main Aug 13, 2021
@zekai427 zekai427 deleted the trino branch August 17, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with Trino java sdk
3 participants