Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor taskmanager config and support deleting HDFS files when dropping tables #3369

Merged
merged 19 commits into from
Sep 15, 2023

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub commented Jul 17, 2023

Breaking change: Remove the deprecated TaskManager config of "namenode.uri".

@tobegit3hub tobegit3hub self-assigned this Jul 17, 2023
@github-actions github-actions bot added the task-manager openmldb taskmanager label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (0462f8a) 75.34% compared to head (daf2864) 75.38%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3369      +/-   ##
============================================
+ Coverage     75.34%   75.38%   +0.03%     
  Complexity      414      414              
============================================
  Files           707      708       +1     
  Lines        128664   128790     +126     
  Branches       1191     1230      +39     
============================================
+ Hits          96943    97088     +145     
+ Misses        31480    31461      -19     
  Partials        241      241              
Files Changed Coverage Δ
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (ø)
...adigm/openmldb/taskmanager/dao/JobIdGenerator.java 0.00% <0.00%> (ø)
...gm/openmldb/taskmanager/server/JobResultSaver.java 0.00% <0.00%> (ø)
...openmldb/taskmanager/server/TaskManagerServer.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/udf/ExternalFunctionManager.java 0.00% <0.00%> (ø)
...adigm/openmldb/taskmanager/zk/FailoverWatcher.java 0.00% <0.00%> (ø)
...paradigm/openmldb/taskmanager/JobInfoManager.scala 0.00% <0.00%> (ø)
...m/_4paradigm/openmldb/taskmanager/LogManager.scala 0.00% <0.00%> (ø)
...adigm/openmldb/taskmanager/k8s/K8sJobManager.scala 0.00% <0.00%> (ø)
... and 5 more

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobegit3hub tobegit3hub changed the title feat: refactor taskmanager config for properties object feat: refactor taskmanager config and support deleting HDFS files when dropping tables Jul 19, 2023
@aceforeverd aceforeverd changed the title feat: refactor taskmanager config and support deleting HDFS files when dropping tables feat!: refactor taskmanager config and support deleting HDFS files when dropping tables Jul 25, 2023
@tobegit3hub tobegit3hub changed the title feat!: refactor taskmanager config and support deleting HDFS files when dropping tables fix: refactor taskmanager config and support deleting HDFS files when dropping tables Sep 6, 2023
release/sbin/deploy-all.sh Outdated Show resolved Hide resolved
@dl239 dl239 merged commit 1792700 into 4paradigm:main Sep 15, 2023
23 of 24 checks passed
dl239 pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants