feat(android, ios, ontableofcontents): update onTableOfContents to re… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn Locator[] for consistency
Links and Locators are not the same and need to be handled differently. To avoid complexity, the
library has been update to only deal with Locators and map all Links it returns to Locators.
BREAKING CHANGE: onTableOfContents now returns a `Locator[]` instead of a `Link[]`. Update your
`onTableOfContents` callbacks from `(toc: Link[]) => {...}` to `(toc: Locator[]) => {...}`.
#11
|
Closing, as this is not the correct solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…turn Locator[] for consistency
Links and Locators are not the same and need to be handled differently. To avoid complexity, the library has been update to only deal with Locators and map all Links it returns to Locators.
BREAKING CHANGE: onTableOfContents now returns a
Locator[]instead of aLink[]. Update youronTableOfContentscallbacks from(toc: Link[]) => {...}to(toc: Locator[]) => {...}.#11