Skip to content

Conversation

@justadreamer
Copy link
Contributor

According to the tests it gives a 1% performance gain compared to version/4.5 branch for a single property, however it seems that for all properties main branch performance dominates, version/4.5 does not seem to improve on it for all properties...

❯ cat summary-main.json
{
  "main":{
    "InMemoryAverage": 762823.41,
    "InMemory_AllAverage": 185975.2
  }, 
  "graph":{
    "InMemoryAverage": 875464.62,
    "InMemory_AllAverage": 174252.81
  },
  "4.5": {
    "InMemoryAverage": 866540.76,
    "InMemory_AllAverage": 171910.55
  }
} 

graph branch compared to version/4.5: 
for a single property:
(875464-866540)/866540*100% = 1.03%

for all properties:
(174252-171910)/174252*100% = 1.34%

@justadreamer justadreamer marked this pull request as draft December 6, 2024 14:22
@jwrosewell
Copy link
Contributor

@justadreamer a better test would be a single property from each of the components available rather than all properties which will be more random.

@Luke51D Luke51D closed this Sep 3, 2025
@Luke51D Luke51D deleted the feature/graph-equal-optim branch September 3, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants