Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Commit

Permalink
Merge pull request #149 from nuest/bugfix/xml2-classes
Browse files Browse the repository at this point in the history
Bugfix release
  • Loading branch information
nuest authored Aug 9, 2019
2 parents 8900f95 + 0682c74 commit ee82659
Show file tree
Hide file tree
Showing 65 changed files with 1,883 additions and 1,803 deletions.
7 changes: 3 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: sos4R
Type: Package
Title: Client for OGC Sensor Observation Services
Version: 0.3.0
Date: 2019-04-13
Version: 0.3.1
Date: 2019-07-09
Authors@R:
c(person(given = "Daniel",
family = "Nuest",
Expand Down Expand Up @@ -32,7 +32,7 @@ Imports:
methods,
sp,
stringr,
xml2,
xml2 (>= 1.2.2),
Suggests:
readr,
spacetime,
Expand Down Expand Up @@ -63,7 +63,6 @@ BugReports: https://github.com/52North/sos4R/issues
Collate:
Constants.R
R-Helper.R
Class-XML.R
Class-OWS.R Class-GML.R Class-SWE.R Class-OM.R Class-SA.R Class-SAMS.R Class-WML_200.R Class-OM_20.R
Class-OGC.R Class-SOS.R Class-SOS_100.R Class-SOS_200.R Class-SOS_200_GDA.R Class-SML.R
Generic-methods.R
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# sos4R 0.3.1

- Bugfix release: don't set classes for `xml2` (requires version `1.2.2`, see #148)

# sos4R 0.3.0

- Switch from `XML` to `xml2`
Expand Down
31 changes: 0 additions & 31 deletions R/Class-XML.R

This file was deleted.

27 changes: 4 additions & 23 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,17 @@
# Test environments

* local R 3.5.3
* local R 3.6.1
* Ubuntu 14.04 (Trusty) on Travis CI
* Windows on Appveyor
* R-Hub
* win-builder (using devtools)
* [skipped because xml2 not latest version] win-builder (using devtools)

## R CMD check results

No errors.
No warnings.

1 NOTE:

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Daniel Nuest <daniel.nuest@uni-muenster.de>'

New submission

Package was archived on CRAN

Possibly mis-spelled words in DESCRIPTION:
Geospatial (36:31)
OGC (3:67, 36:54)

CRAN repository db overrides:
X-CRAN-Comment: Archived on 2018-06-17 as check problems were not
corrected despite reminders.
No notes.

## Other

The package was "archived on 2018-06-17 as check problems were not corrected despite reminders."
Issues could now finally be resolved with a complete overhaul of implementation (switching from XML to xml2) and we kindly request re-publication on CRAN.

Comments during manual inspection were handled with this resubmission.
This is a bugfix release following the publication of xml2 version 1.2.2.
6 changes: 3 additions & 3 deletions docs/DEV-README.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/articles/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ee82659

Please sign in to comment.