Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and fix formatter, linter and test suite #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve and fix formatter, linter and test suite #19

wants to merge 5 commits into from

Conversation

alorle
Copy link

@alorle alorle commented Dec 11, 2024 •
edited
Loading

  • Rename jsxBracketSameLine to bracketSameLine in Prettier config
  • Add Jest plugin and Prettier shared config to Eslint
  • Follow Jest defaults for config file naming so IDE can find testing confi file by default
  • Format all files to follow Prettier format

@LeWricka LeWricka self-requested a review December 11, 2024 14:41
@alorle alorle force-pushed the christmas-lights-kata branch from 668ba22 to 1049952 Compare December 11, 2024 15:12
@alorle
chore(prettier): use new option to set bracket same line
dbf53c7 
Signed-off-by: Álvaro Orduna León <4264243+alorle@users.noreply.github.com>
@alorle
chore(eslint): add prettier and jest shared configs
28dbe54 
Signed-off-by: Álvaro Orduna León <4264243+alorle@users.noreply.github.com>
@alorle
tests: fix jest config
d8f3df0 
Signed-off-by: Álvaro Orduna León <4264243+alorle@users.noreply.github.com>
@alorle
style: follow prettier rules
7923e66
@alorle
docs: remove deprecated step
70bddf4 
Signed-off-by: Álvaro Orduna León <4264243+alorle@users.noreply.github.com>
@alorle alorle force-pushed the christmas-lights-kata branch from 1049952 to 70bddf4 Compare December 11, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeWricka LeWricka Awaiting requested review from LeWricka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alorle