Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eat own dog food. #10

Closed
lijunle opened this issue Nov 14, 2015 · 4 comments
Closed

Eat own dog food. #10

lijunle opened this issue Nov 14, 2015 · 4 comments

Comments

@lijunle
Copy link
Contributor

lijunle commented Nov 14, 2015

Unit test is important. However, it could be great to integrate this plugin back to itself - export default then require to test the exported stuffs.

If we are going to do it in test code, the test code needs to convert to ES6 syntax.

@59naga Any ideas?

@59naga
Copy link
Owner

59naga commented Nov 15, 2015

Behavior is now flat.
Tests Let's finish flat.

@lijunle
Copy link
Contributor Author

lijunle commented Nov 18, 2015

What is the meaning of flat here?

@59naga
Copy link
Owner

59naga commented Nov 19, 2015

I've used flat meant providing a single function.
Currently, this plug-in, do the locally modifications to babel@6.
But the future, flat might be difficult for given the compatibility of babel@7.

Notice the __esModule flag, babel import behavior depends on this magic flag. Then, at the end of lines, you are assigning exports.default back to module.exports. After this assignment, __esModule flag is lost.
lijunle commented 2015-11-18T12:53:54Z

(As you said) I also think need to bit more consider a test case.

@lijunle
Copy link
Contributor Author

lijunle commented Apr 26, 2016

Closing this by #33

@lijunle lijunle closed this as completed Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants