Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.1.3 is breaking changes? #31

Closed
iam4x opened this issue Apr 26, 2016 · 5 comments
Closed

v0.1.3 is breaking changes? #31

iam4x opened this issue Apr 26, 2016 · 5 comments
Labels
bug

Comments

@iam4x
Copy link

iam4x commented Apr 26, 2016

Hello,

We use this plugin in our babel preset (https://github.com/savemysmartphone/babel-preset-save), the minor update broke our builds.

I had to suffix the require() call to the plugin with .default see here: savemysmartphone/babel-preset-save@3c9d679

Is this normal behaviour? What happened? I can't find in the commit, this is just for personal knowledge. Thanks.
@59naga 59naga added the bug label Apr 26, 2016
@59naga
Copy link
Owner

59naga commented Apr 26, 2016 •
edited
Loading

hmm... 0.1.3 no longer used the module.exports.
It has broken the compatibility of babel-presets.

@iam4x
Copy link
Author

iam4x commented Apr 26, 2016

Alright, thank's. Would be great to publish a major for breaking changes like that 👍

@jquense
Copy link

jquense commented Apr 26, 2016

this plugin needs to use itself :P

jquense added a commit to jquense/babel-plugin-add-module-exports that referenced this issue Apr 26, 2016
@jquense
fix module exports
efb7bc4 
fixes 59naga#31
This was referenced Apr 26, 2016
Closed
Closed
@lijunle
Copy link
Contributor

lijunle commented Apr 26, 2016 •
edited by 59naga
Loading

It is on track actually 😄 #10

@59naga 59naga mentioned this issue Apr 26, 2016
Merged
@59naga 59naga closed this as completed in 8471534 Apr 26, 2016
59naga added a commit that referenced this issue Apr 26, 2016
@59naga
Merge pull request #33 from 59naga/patch-1
8c39825 
fix #31 plugin should export using module.exports
@59naga
Copy link
Owner

59naga commented Apr 26, 2016

this issue has been resolved in v0.1.4. thanks @iam4x 👍

iam4x added a commit to savemysmartphone/babel-preset-save that referenced this issue Apr 27, 2016
@iam4x
Revert "fix(add-module-exports): use .default"
63a42d8 
This reverts commit 3c9d679.
See 59naga/babel-plugin-add-module-exports#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
4 participants
@jquense @iam4x @lijunle @59naga