Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use babel/scripts/add-module-exports as reference implementation. #34

Closed
jdalton opened this issue May 12, 2016 · 4 comments
Closed

Use babel/scripts/add-module-exports as reference implementation. #34

jdalton opened this issue May 12, 2016 · 4 comments
Labels
using babel-types

Comments

@jdalton
Copy link

jdalton commented May 12, 2016

See babel/scripts/add-module-exports.js.
@59naga
Copy link
Owner

59naga commented May 12, 2016

hmm..., in this case, the plug-in will become uneditable in this repository.
and, i care the reason that has been placed in the packages rather than scripts. 😕

@jdalton
Copy link
Author

jdalton commented May 12, 2016

It's likely to be moved from scripts to a core plugin or as an option on the existing commonjs plugin.
That said, it doesn't prevent you from using their implementation as a reference for this plugin for the time being.

@59naga
Copy link
Owner

59naga commented May 12, 2016

understood. adjust my code.

59naga added a commit that referenced this issue May 12, 2016
@59naga
perf: use babel/scripts/add-module-exports as reference implementation(…
77cc52a 
…#34)

- use `babel-types` instead of `babel-template`
- use `path.node.specifiers` instead of `path.get('declaration').container.specifiers`

refs: https://github.com/babel/babel/blob/v6.8.1/scripts/add-module-exports.js
@59naga
Copy link
Owner

59naga commented May 12, 2016

this change was applied as v0.2.1 now. thanks @jdalton 👍

@59naga 59naga closed this as completed May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
using babel-types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @59naga