Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): Mutate logic update #198

Merged
merged 11 commits into from
Jun 27, 2024
Merged

(chore): Mutate logic update #198

merged 11 commits into from
Jun 27, 2024

Conversation

VedRatan
Copy link
Collaborator

Description

This PR introduces the new strategy to apply mutate kyverno policies, for namespace nimbus policies. For ClusterPolicy the work is in progress.

Fixes # (issue)

Does this PR introduce a breaking change?

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

VedRatan added 2 commits June 26, 2024 05:44
@VedRatan
updated mutate logic for namespaced policy
70c532a 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan
added example
794b380 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan VedRatan force-pushed the mutate_logic_update branch from 3ed0b2e to 4b00b30 Compare June 26, 2024 06:32
VedRatan added 2 commits June 26, 2024 22:56
@VedRatan
added modifications for review comments
7b16513 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan
remove unwanted files
1cde4f5 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan VedRatan requested a review from shivaccuknox June 26, 2024 17:31
VedRatan added 5 commits June 27, 2024 00:26
@VedRatan
edge case
18a5b2d 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan
updated the selector
e55789a 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan
reverted si-sib
de6beda 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan
refactored and fixed the clusterpol logic
de53a30 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan
cleared cpol bugs
2294742 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
shivaccuknox
shivaccuknox previously approved these changes Jun 27, 2024
View reviewed changes
@VedRatan
resolved all the comments and fixed test
be15bae 
Signed-off-by: Ved Ratan <vedratan8@gmail.com>
@VedRatan VedRatan requested a review from shivaccuknox June 27, 2024 07:40
@shivaccuknox shivaccuknox merged commit 4a700b4 into 5GSEC:main Jun 27, 2024
12 checks passed
@VedRatan VedRatan deleted the mutate_logic_update branch June 27, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivaccuknox shivaccuknox shivaccuknox approved these changes

@anurag-rajawat anurag-rajawat Awaiting requested review from anurag-rajawat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VedRatan @shivaccuknox